Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add search bar to nav bar #1533

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: add search bar to nav bar #1533

wants to merge 11 commits into from

Conversation

hroth1994
Copy link
Contributor

@hroth1994 hroth1994 commented Sep 19, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Adds a search bar component to the nav bar, currently only for desktop views. This is not meant to be perfect, but rather a first pass at a search bar to be integrated into es-cms-pages
Adds a prop to the nav bar showSearch to enable the search icon. Defaults to false as to not affect existing functionality.

πŸ₯Ό Testing

Tested locally at http://localhost:8500/organisms/es-nav-bar - click search icon to open/close, x icon also closes search bar
Screenshot 2024-09-19 at 4 18 25β€―PM

🧐 Feedback Requested / Focus Areas

  • General

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
  • I have documented testing approach

Copy link
Collaborator

@nathanielwarner nathanielwarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants